Issue resolved #19607. Page Not Found when deleting Attribute Set

[cedcommerce]

Description (*)

Page Not Found when deleting Attribute Set

Fixed Issues (if relevant)

1. magento/magento2 Magento 2.3. Page Not Found when deleting Attribute Set #19607: Page Not Found when deleting Attribute Set

Manual testing scenarios (*)

1. Delete a product attribute set.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @cedcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[sivaschenko]

Hi @cedcommerce , thanks for the contribution. Delete operation should be performed using post request. So I think it is the actual request that is incorrect, not the controller marker.

Could you please take a look if it's possible to update the delete button here:

magento2/app/code/Magento/Catalog/Block/Adminhtml/Product/Attribute/Set/Main.php

Lines 130 to 146 in 8c2e178

	$this->getToolbar()->addChild(
	'delete_button',
	\Magento\Backend\Block\Widget\Button::class,
	[
	'label' => __('Delete'),
	'onclick' => 'deleteConfirm(\'' . $this->escapeJs(
	__(
	'You are about to delete all products in this attribute set. '
	. 'Are you sure you want to do that?'
	)
	) . '\', \'' . $this->getUrl(
	'catalog/*/delete',
	['id' => $setId]
	) . '\')',
	'class' => 'delete'
	]
	);

It might requeire some update to javascript here:

magento2/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/set/main.phtml

Line 209 in 8c2e178

editSet = function () {

[cedcommerce]

ok @sivaschenko , i am checking the same. as it was a get request that's why i made changes on controller.I will update soon.