Checkout / Sales Rules / Get rid of redundant DB query #29376

lbajsarowicz · 2020-08-04T08:08:48Z

Description (*)

Loading data in the loop?

No, thank you!

By replacing direct SQL query with Data Provider that was already used in this Validator class allowed me to drastically reduce the cost of checkout placing process.

Local environment

20 products in cart

Custom project

22 products in cart

Related Pull Requests

Fixed Issues (if relevant)

Performance of Checkout

Manual testing scenarios (*)

Install sample data
Create Catalog rule based on category
Add plenty of products (15 - inf.)
Place an order.

Enjoy the pleasure of the checkout faster by 20 - 30% (and/or) send me a good whiskey

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Checkout / Sales Rules / Get rid of redundant DB query #29453: Checkout / Sales Rules / Get rid of redundant DB query

m2-assistant · 2020-08-04T08:08:50Z

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

lbajsarowicz · 2020-08-04T08:11:58Z

@magento run all tests

ihor-sviziev · 2020-08-04T08:22:10Z

@slavvka @lenaorobei is there an ability to run performance against 2.4-develop and for this PR? Would be good to check the diff. I think this is the only one way to measure this improvement with automated tests

IvanChepurnyi · 2020-08-04T08:45:30Z

Nice performance optimization @lbajsarowicz, would be great also to remove the singular query with preloaded category ids into this service by using afterload even on product collection in the shopping cart.

lbajsarowicz · 2020-08-04T09:01:27Z

@magento run Static Tests, Unit Tests

These failed due to implementation testing. SVC has to be approved by Magento crew.

ihor-sviziev

Hi @lbajsarowicz,
Could you implement following suggestion? #29376 (comment)

lbajsarowicz · 2020-08-04T11:20:44Z

@ihor-sviziev That is the subject for another PR.
With the delays caused by Product Owners from Adobe, I'd prefer to do it separately.

(This will require a set of additional Integration tests)

ihor-sviziev · 2020-08-04T11:50:34Z

@lbajsarowicz I don't mind to improve solution with small steps.
@magento run all tests

ihor-sviziev

✔ Approved.

Failing SVC test looks false positive

magento-engcom-team · 2020-08-04T14:08:30Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7950 has been created to process this Pull Request

lbajsarowicz · 2020-08-06T11:09:32Z

@magento run all tests

I just rolled back PHPDoc clarification, to avoid Magento approval procedures hell.

engcom-Charlie · 2020-08-06T11:11:52Z

@magento run all tests

magento-engcom-team · 2020-08-06T19:31:45Z

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7950 has been created to process this Pull Request

engcom-Alfa · 2020-08-07T11:30:28Z

✔️ QA Passed

Manual testing scenario:

Install Magento with sample data
Create Catalog rule based on category
Add plenty of products (50 in my case)
Place an order.

Local environment

Before: ✖️

After: ✔️
50 products in cart

engcom-Alfa · 2020-08-10T10:50:22Z

@magento create issue

…29376

m2-assistant · 2020-08-15T06:22:27Z

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Replace load in the loop with proper data provider

d8a386e

ghost added the Progress: pending review label Aug 4, 2020

magento-engcom-team added Component: Rule Release Line: 2.4 Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner labels Aug 4, 2020

ihor-sviziev added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Aug 4, 2020

ihor-sviziev self-assigned this Aug 4, 2020

ihor-sviziev added Award: bug fix Award: category of expertise Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Aug 4, 2020

Fix failing Tests (Static, Unit)

2c18740

ihor-sviziev requested changes Aug 4, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: pending review labels Aug 4, 2020

ghost added Progress: pending review and removed Progress: needs update labels Aug 4, 2020

ihor-sviziev previously approved these changes Aug 4, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: pending review labels Aug 4, 2020

magento-engcom-team added the Component: SalesRule label Aug 4, 2020

engcom-Alfa self-assigned this Aug 6, 2020

ghost assigned lbajsarowicz Aug 6, 2020

Merge branch '2.4-develop' into performance/checkout-sales-rule-validate

1a77014

ghost added Progress: review and removed Progress: to approve labels Aug 6, 2020

ihor-sviziev approved these changes Aug 6, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: review labels Aug 6, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Aug 7, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Aug 7, 2020

engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Aug 7, 2020

m2-assistant bot mentioned this pull request Aug 10, 2020

[Issue] Checkout / Sales Rules / Get rid of redundant DB query #29453

Closed

4 tasks

engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 11, 2020

ghost added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept and removed Progress: extended testing labels Aug 13, 2020

magento-engcom-team pushed a commit that referenced this pull request Aug 15, 2020

ENGCOM-7950: Checkout / Sales Rules / Get rid of redundant DB query #…

d95b3e0

…29376

magento-engcom-team merged commit be1ca7f into magento:2.4-develop Aug 15, 2020

This was referenced Aug 15, 2020

Refactor Category Link: Replace deprecated interface, clean the code #29564

Merged

Use Object Cache for Category Links to avoid redundant calls #29565

Closed

This was referenced Aug 18, 2020

[Issue] Use Object Cache for Category Links to avoid redundant calls #29654

Closed

[Issue] Refactor Category Link: Replace deprecated interface, clean the code #29679

Closed

Checkout / Sales Rules / Get rid of redundant DB query #29376

Checkout / Sales Rules / Get rid of redundant DB query #29376

Uh oh!

Conversation

lbajsarowicz commented Aug 4, 2020 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Local environment

Custom project

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Aug 4, 2020

Uh oh!

lbajsarowicz commented Aug 4, 2020

Uh oh!

ihor-sviziev commented Aug 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

IvanChepurnyi commented Aug 4, 2020

Uh oh!

lbajsarowicz commented Aug 4, 2020

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

lbajsarowicz commented Aug 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ihor-sviziev commented Aug 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Aug 4, 2020

Uh oh!

lbajsarowicz commented Aug 6, 2020

Uh oh!

engcom-Charlie commented Aug 6, 2020

Uh oh!

magento-engcom-team commented Aug 6, 2020

Uh oh!

engcom-Alfa commented Aug 7, 2020

Uh oh!

engcom-Alfa commented Aug 10, 2020

Uh oh!

m2-assistant bot commented Aug 15, 2020

Uh oh!

Uh oh!

lbajsarowicz commented Aug 4, 2020 •

edited by m2-assistant bot

Loading

ihor-sviziev commented Aug 4, 2020 •

edited

Loading

lbajsarowicz commented Aug 4, 2020 •

edited

Loading

ihor-sviziev commented Aug 4, 2020 •

edited

Loading