Skip to content

Strip objectId out of responses from HooksController #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TylerBrock
Copy link
Contributor

@TylerBrock TylerBrock commented May 26, 2016

Saw this during testing today:

Results from api.parse.com query to /hooks/triggers:

{
  "results": [
    {
      "triggerName": "beforeSave",
      "className": "blah",
      "url": "https://xxx"
    }
  ]
}

Results from parse-server query to /hook/triggers:

{
  "results": [
    {
      "objectId": "57464f6830ba6971a3025cbc",
      "triggerName": "beforeSave",
      "className": "blah",
      "url": "xxx"
    }
  ]
}

Approach seems ok-ish...

@TylerBrock TylerBrock force-pushed the strip-object-ids-hooks branch from 7364d23 to 1f2efa1 Compare May 26, 2016 21:43
@TylerBrock TylerBrock added the type:bug Impaired feature or lacking behavior that is likely assumed label May 26, 2016
@drew-gross
Copy link
Contributor

Makes sense to me. Can you add a regression test then merge?

@codecov-io
Copy link

codecov-io commented May 26, 2016

Current coverage is 91.86%

Merging #1925 into master will increase coverage by <.01%

  1. File ...uters/HooksRouter.js was modified. more
@@             master      #1925   diff @@
==========================================
  Files            91         91          
  Lines          6391       6397     +6   
  Methods        1111       1115     +4   
  Messages          0          0          
  Branches       1338       1338          
==========================================
+ Hits           5870       5876     +6   
  Misses          521        521          
  Partials          0          0          

Powered by Codecov. Last updated by dd1d18d...9699a92

@flovilmart
Copy link
Contributor

Id put it in the hooksController instead of the router no?

@TylerBrock
Copy link
Contributor Author

Sure, we can do that.

@TylerBrock TylerBrock force-pushed the strip-object-ids-hooks branch from 1f2efa1 to bc94501 Compare May 26, 2016 22:13
@TylerBrock
Copy link
Contributor Author

Ok, new codes, much simpler.

@ghost
Copy link

ghost commented May 26, 2016

@TylerBrock updated the pull request.

@TylerBrock TylerBrock force-pushed the strip-object-ids-hooks branch from bc94501 to f5ccf7e Compare May 26, 2016 22:15
@ghost
Copy link

ghost commented May 26, 2016

@TylerBrock updated the pull request.

@TylerBrock TylerBrock merged commit c5e3be8 into parse-community:master May 26, 2016
@mtrezza mtrezza removed the type:bug Impaired feature or lacking behavior that is likely assumed label Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants