2.x to become the new master #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adjust client signatures * Lock lower bounds for test dependencies * Use leanphp/phpspec-code-coverage as a maintained fork
Remove deprecated plugin option 'debug_plugins'
Complete removal of debug_plugins
[2.0] Add PHP-CS-Ffixer
* Add types where possible * Add spec to autoload-dev * Fix signatures * Use ::class anywhere * Add `: Promise` return type to Plugin::handleRequest
Make RedirectPlugin final
We add interfaces for final classes so that they can be mocked in testing. We chose to use the Interface suffix here to avoid name clashes, rather than renaming the existing PHP classes. The interfaces are only relevant for unit testing, we do not expect people to provide their own implementations. HttpClientPoolItem is purely internal and we therefore don't want an interface for it. It is marked with @Final and explained to not be meant to extend.
mark classes as final and methods and properties as private
Remove php-cs-fixer from dependencies
Test on PHP 7.3
Typecheck for PSR-18 ClientInterface instead of Httplug Client interface. Our interface extends the PSR-18 ClientInterface and therefore is still accepted. No changes for the async client as there is no PSR for that (yet)
fix cs violation introduced when merging master to 2.x
Functional test to ensure no issue with plugins in sync nor async requests
|
I suggest merging this to master now. I've created a 1.x branch |
|
agreed. i'll try to solve the merge conflicts. |
Update from master
add missing type declarations
dbu
reviewed
Jan 3, 2019
|
Thank you for fixing the merge conflicts. |
|
What about dropping PHP 7.0? |
|
I just suggest to merge to master. Not to tag 2.0. About PHP 7.0: #148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to show that we have a 2.x branch.
It should be merged after we release 1.9.