Skip to content

Add navigation tabs to the crate details pages #3330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 25, 2021
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Feb 25, 2021

Bildschirmfoto 2021-02-25 um 16 28 25

Bildschirmfoto 2021-02-25 um 16 28 38

Not visible on the screenshots: if you're a crate owner then a fourth "Settings" tab will also be visible

This should also resolve #3321

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-frontend 🐹 labels Feb 25, 2021
@pichfl
Copy link

pichfl commented Feb 25, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Feb 25, 2021

📌 Commit fb973e7 has been approved by pichfl

@bors
Copy link
Contributor

bors commented Feb 25, 2021

⌛ Testing commit fb973e7 with merge 7a6a81e...

bors added a commit that referenced this pull request Feb 25, 2021
Add navigation tabs to the crate details pages

<img width="825" alt="Bildschirmfoto 2021-02-25 um 16 28 25" src="https://user-images.githubusercontent.com/141300/109175925-97246580-7786-11eb-8f2a-496b288aca6a.png">

<img width="506" alt="Bildschirmfoto 2021-02-25 um 16 28 38" src="https://user-images.githubusercontent.com/141300/109175920-94297500-7786-11eb-92e9-b86206abfdf2.png">

Not visible on the screenshots: if you're a crate owner then a fourth "Settings" tab will also be visible

This should also resolve #3321
This is now much more prominently displayed as a dedicated tab
@Turbo87
Copy link
Member Author

Turbo87 commented Feb 25, 2021

@bors r=pichfl

fixed the broken tests 😉

@bors
Copy link
Contributor

bors commented Feb 25, 2021

📌 Commit 2849e70 has been approved by pichfl

@bors
Copy link
Contributor

bors commented Feb 25, 2021

⌛ Testing commit 2849e70 with merge 19ef907...

@bors
Copy link
Contributor

bors commented Feb 25, 2021

☀️ Test successful - checks-actions
Approved by: pichfl
Pushing 19ef907 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve prominence of "dependent crates" link
5 participants