Suggest correct version("..") predicate syntax in check-cfg
#141456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 24, 2025
…eyouxu
Suggest correct `version("..")` predicate syntax in check-cfg
This PR specialize the `unexpected_cfgs` lint diagnostic to suggest correct `version("..")` predicate syntax when providing the key-value one, eg. `version = "1.27"`.
Fixes rust-lang#141440
r? `@jieyouxu`
This was referenced May 24, 2025
bors
added a commit
that referenced
this pull request
May 24, 2025
Rollup of 7 pull requests Successful merges: - #141405 (GetUserProfileDirectoryW is now documented to always store the size) - #141427 (Disable `triagebot`'s `glacier` handler) - #141429 (Dont walk into unsafe binders when emiting error for non-structural type match) - #141438 (Do not try to confirm non-dyn compatible method) - #141444 (Improve CONTRIBUTING.md grammar and clarity) - #141446 (Add 2nd Solaris target maintainer) - #141456 (Suggest correct `version("..")` predicate syntax in check-cfg) r? `@ghost` `@rustbot` modify labels: rollup
bors
added
S-waiting-on-author
|
@est31, it's #141413 (comment) that was kick out of the queue, not this PR, and this PR has already being included in another rollup anyway #141484. Sorry for the concurrent and conflicting PR. @bors r=jieyouxu |
bors
added
S-waiting-on-bors
|
Ah good point, the PRs were conflicting, i.e. both passing on their own but the combination wasn't. Yeah, one needs to go first, so it's fine to have this one I guess. |
rust-timer
added a commit
that referenced
this pull request
May 24, 2025
Rollup merge of #141456 - Urgau:check-cfg-version-pred, r=jieyouxu Suggest correct `version("..")` predicate syntax in check-cfg This PR specialize the `unexpected_cfgs` lint diagnostic to suggest correct `version("..")` predicate syntax when providing the key-value one, eg. `version = "1.27"`. Fixes #141440 r? ``@jieyouxu``
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
May 26, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#141405 (GetUserProfileDirectoryW is now documented to always store the size) - rust-lang#141427 (Disable `triagebot`'s `glacier` handler) - rust-lang#141429 (Dont walk into unsafe binders when emiting error for non-structural type match) - rust-lang#141438 (Do not try to confirm non-dyn compatible method) - rust-lang#141444 (Improve CONTRIBUTING.md grammar and clarity) - rust-lang#141446 (Add 2nd Solaris target maintainer) - rust-lang#141456 (Suggest correct `version("..")` predicate syntax in check-cfg) r? `@ghost` `@rustbot` modify labels: rollup
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR specialize the
unexpected_cfgslint diagnostic to suggest correctversion("..")predicate syntax when providing the key-value one, eg.version = "1.27".Fixes #141440
r? @jieyouxu