Rollup of 8 pull requests

[matthiaskrgr]

Successful merges:

• GetUserProfileDirectoryW is now documented to always store the size #141405 (GetUserProfileDirectoryW is now documented to always store the size)
• Make #[cfg(version)] respect RUSTC_OVERRIDE_VERSION_STRING #141413 (Make #[cfg(version)] respect RUSTC_OVERRIDE_VERSION_STRING)
• Disable triagebot's glacier handler #141427 (Disable triagebot's glacier handler)
• Dont walk into unsafe binders when emiting error for non-structural type match #141429 (Dont walk into unsafe binders when emiting error for non-structural type match)
• Do not try to confirm non-dyn compatible method #141438 (Do not try to confirm non-dyn compatible method)
• Improve CONTRIBUTING.md grammar and clarity #141444 (Improve CONTRIBUTING.md grammar and clarity)
• Add 2nd Solaris target maintainer #141446 (Add 2nd Solaris target maintainer)
• Suggest correct version("..") predicate syntax in check-cfg #141456 (Suggest correct version("..") predicate syntax in check-cfg)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit 8bd0ebd has been approved by matthiaskrgr

It is now in the queue for this repository.

[rust-log-analyzer]

The job x86_64-gnu-llvm-19 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#18 exporting to docker image format
#18 sending tarball 20.6s done
#18 DONE 27.6s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-19]
[CI_JOB_NAME=x86_64-gnu-llvm-19]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Listening on address 127.0.0.1:4226
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-19', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'build.print-step-timings', '--enable-verbose-tests', '--set', 'build.metrics', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--set', 'gcc.download-ci-gcc=true', '--enable-new-symbol-mangling']
configure: build.build          := x86_64-unknown-linux-gnu
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-19/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
4 LL | #[cfg(not(version = "1.48.0"))]
5    |           ^^^^^^^^^^^^^^^^^^
6    |
-    = help: expected names are: `FALSE` and `test` and 31 more
8    = help: to expect this configuration use `--check-cfg=cfg(version, values("1.48.0"))`
9    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg.html> for more information about checking conditional configuration
10    = note: `#[warn(unexpected_cfgs)]` on by default

+ help: there is a similar config predicate: `version("..")`
+    |
+ LL - #[cfg(not(version = "1.48.0"))]
+ LL + #[cfg(not(version("1.48.0")))]
+    |
11 
12 warning: 1 warning emitted
13 

Note: some mismatched output was normalized before being compared
- LL - #[cfg(not(version = "1.48.0"))] //~ WARN unexpected `cfg` condition name: `version`
- LL + #[cfg(not(version("1.48.0")))] //~ WARN unexpected `cfg` condition name: `version`
+ help: there is a similar config predicate: `version("..")`
+    |
+ LL - #[cfg(not(version = "1.48.0"))]
+ LL + #[cfg(not(version("1.48.0")))]
+    |


The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args feature-gates/cfg-version-expand.rs`

error: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUSTC_OVERRIDE_VERSION_STRING="1.50.3" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/feature-gates/cfg-version-expand.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "-O" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/feature-gates/cfg-version-expand/a" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
stdout: none
--- stderr -------------------------------
warning: unexpected `cfg` condition name: `version`
##[warning]  --> /checkout/tests/ui/feature-gates/cfg-version-expand.rs:15:11
   |
LL | #[cfg(not(version = "1.48.0"))] //~ WARN unexpected `cfg` condition name: `version`
   |           ^^^^^^^^^^^^^^^^^^
   |
   = help: to expect this configuration use `--check-cfg=cfg(version, values("1.48.0"))`
   = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg.html> for more information about checking conditional configuration
   = note: `#[warn(unexpected_cfgs)]` on by default
help: there is a similar config predicate: `version("..")`
   |
LL - #[cfg(not(version = "1.48.0"))] //~ WARN unexpected `cfg` condition name: `version`
LL + #[cfg(not(version("1.48.0")))] //~ WARN unexpected `cfg` condition name: `version`
   |

warning: 1 warning emitted
------------------------------------------