-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add correct use for Error and io #30712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This also repeated the case analysis used.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
r? @BurntSushi |
@bors r+ |
📌 Commit ca1f0c9 has been approved by |
⌛ Testing commit ca1f0c9 with merge 7d80fb4... |
💔 Test failed - auto-linux-64-nopt-t |
@bors retry rollup |
@@ -1795,6 +1795,10 @@ To convert this to proper error handling, we need to do the following: | |||
Let's try it: | |||
|
|||
```rust,ignore | |||
use std::error::Error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing semicolon
This also repeats the case analysis used.
This also repeats the case analysis used.
@bors: retry |
err actually new commit @bors: r+ rollup |
📌 Commit 0ca33ad has been approved by |
…bnik This also repeats the case analysis used.
…bnik This also repeats the case analysis used.
This also repeats the case analysis used.