Skip to content

Add correct use for Error and io #30712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2016
Merged

Conversation

lawrencewoodman
Copy link
Contributor

This also repeats the case analysis used.

This also repeated the case analysis used.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Manishearth
Copy link
Member

r? @BurntSushi

@BurntSushi
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 5, 2016

📌 Commit ca1f0c9 has been approved by BurntSushi

@bors
Copy link
Collaborator

bors commented Jan 5, 2016

⌛ Testing commit ca1f0c9 with merge 7d80fb4...

@bors
Copy link
Collaborator

bors commented Jan 5, 2016

💔 Test failed - auto-linux-64-nopt-t

@Manishearth
Copy link
Member

@bors retry rollup

@@ -1795,6 +1795,10 @@ To convert this to proper error handling, we need to do the following:
Let's try it:

```rust,ignore
use std::error::Error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing semicolon

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 5, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 5, 2016
@steveklabnik
Copy link
Member

@bors: retry

@steveklabnik
Copy link
Member

err actually new commit

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 14, 2016

📌 Commit 0ca33ad has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 14, 2016
…bnik

This also repeats the case analysis used.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 14, 2016
…bnik

This also repeats the case analysis used.
bors added a commit that referenced this pull request Jan 14, 2016
@bors bors merged commit 0ca33ad into rust-lang:master Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants