Skip to content

doc: "x" is used as variable name on this API, so avoid using it here #30909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2016
Merged

doc: "x" is used as variable name on this API, so avoid using it here #30909

merged 1 commit into from
Jan 15, 2016

Conversation

tshepang
Copy link
Member

For a moment, I got confused by thinking the summary was referring to the same x

@rust-highfive
Copy link
Contributor

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member

@bors: r+ rollup

thank you for all these improvements!

@bors
Copy link
Collaborator

bors commented Jan 14, 2016

📌 Commit 80d2be9 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 14, 2016
For a moment, I got confused by thinking the summary was referring to the same `x`
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 14, 2016
For a moment, I got confused by thinking the summary was referring to the same `x`
@tshepang
Copy link
Member Author

Thanks @steveklabnik for you quick responses

bors added a commit that referenced this pull request Jan 14, 2016
@bors bors merged commit 80d2be9 into rust-lang:master Jan 15, 2016
@tshepang tshepang deleted the a-better-name branch January 15, 2016 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants