Rollup of 8 pull requests #30915
Closed
Rollup of 8 pull requests #30915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Jan 14, 2016
steveklabnik
commented
- Successful merges: Add correct use for Error and io #30712, Fix note about B-prefixed issue labels #30895, Fix outdated comment #30902, doc: "x" is used as variable name on this API, so avoid using it here #30909, doc: "move" has a specific meaning in Rust, so avoid using it here #30910, doc: add missing word #30911, doc: that suffix serves as mere distraction #30912, doc: this is more easy to read, and less prone mis-interpretation #30914
- Failed merges:
This also repeated the case analysis used.
'B' labels are for blockers, not issues which belong elsewhere. Prompted by this comment on Reddit: https://www.reddit.com/r/rust/comments/40nzkd/contributing_to_the_rust_compiler_a_short_guide/cyxcjtd
This feature is partially stabilized, so describe each part in the appropriate place.
Also, whitespace fixes
This function returns the size on the stack, not that of the value that may be allocated on the heap.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
…bnik This also repeats the case analysis used.
'B' labels are for blockers, not issues which belong elsewhere. Prompted by this comment on Reddit: https://www.reddit.com/r/rust/comments/40nzkd/contributing_to_the_rust_compiler_a_short_guide/cyxcjtd
…richton This feature is partially stabilized, so describe each part in the appropriate place. r? @alexcrichton @brson It would be nice to backport this to beta, since this is the first release where this is true. I try really hard to not do doc backports, but this isn't very large, and might be worth making an exception, I dunno.
For a moment, I got confused by thinking the summary was referring to the same `x`
Also, whitespace fixes
…eklabnik This function returns the size on the stack, not that of the value that may be allocated on the heap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.