Skip to content

Rename main theme into light theme #49445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2018
Merged

Rename main theme into light theme #49445

merged 1 commit into from
Mar 30, 2018

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 28, 2018
@QuietMisdreavus
Copy link
Member

Please also modify the text in src/doc/rustdoc/src/unstable-features.md so that the sections talking about --themes and --theme-checker mention the "light" theme instead of the "main" theme.

@GuillaumeGomez
Copy link
Member Author

Done.

@QuietMisdreavus
Copy link
Member

The docs you did change weren't even the ones i was thinking of, lol. It's these sections here: https://doc.rust-lang.org/nightly/rustdoc/unstable-features.html#--themes-provide-additional-themes

@GuillaumeGomez
Copy link
Member Author

Done as well.

@QuietMisdreavus
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 29, 2018

📌 Commit 772a802 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Mar 29, 2018
@kennytm
Rollup merge of rust-lang#49445 - GuillaumeGomez:light-theme, r=Quiet…
eb3e2fe 
…Misdreavus

Rename main theme into light theme

r? @QuietMisdreavus
@kennytm kennytm mentioned this pull request Mar 29, 2018
Merged
bors added a commit that referenced this pull request Mar 30, 2018
@bors
Auto merge of #49489 - kennytm:rollup, r=kennytm
d8a1bc7 
Rollup of 10 pull requests

- Successful merges: #49443, #49445, #49446, #49463, #49464, #49466, #49468, #49473, #49484, #49486
- Failed merges:
@bors bors merged commit 772a802 into rust-lang:master Mar 30, 2018
@GuillaumeGomez GuillaumeGomez deleted the light-theme branch March 30, 2018 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @QuietMisdreavus @bors @rust-highfive