Skip to content

Explicitly mention Option in ? error message. #49446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2018
Merged

Explicitly mention Option in ? error message. #49446

merged 1 commit into from
Mar 30, 2018

Conversation

frewsxcv
Copy link
Member

Save users the time/effort of having to lookup what types implement
the Try trait.

@frewsxcv
Explicitly mention Option in ? error message.
1f143bc 
Save users the time/effort of having to lookup what types implement
the `Try` trait.
@frewsxcv frewsxcv force-pushed the frewsxcv-mention-optiono branch from f0acde2 to 1f143bc Compare March 28, 2018 11:04
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Mar 28, 2018 •
edited
Loading

Thanks!

Isn't an issue related to this PR? If so, can you add a link to it please?

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 28, 2018

📌 Commit 1f143bc has been approved by GuillaumeGomez

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 28, 2018
@bors
Copy link
Collaborator

bors commented Mar 28, 2018

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Mar 28, 2018

📌 Commit 1f143bc has been approved by GuillaumeGomez

kennytm added a commit to kennytm/rust that referenced this pull request Mar 29, 2018
@kennytm
Rollup merge of rust-lang#49446 - frewsxcv:frewsxcv-mention-optiono, …
d06abdb 
…r=GuillaumeGomez

Explicitly mention `Option` in `?` error message.

Save users the time/effort of having to lookup what types implement
the `Try` trait.
@kennytm kennytm mentioned this pull request Mar 29, 2018
Merged
bors added a commit that referenced this pull request Mar 30, 2018
@bors
Auto merge of #49489 - kennytm:rollup, r=kennytm
d8a1bc7 
Rollup of 10 pull requests

- Successful merges: #49443, #49445, #49446, #49463, #49464, #49466, #49468, #49473, #49484, #49486
- Failed merges:
@bors bors merged commit 1f143bc into rust-lang:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frewsxcv @GuillaumeGomez @bors