Rollup of 10 pull requests #49489
Merged
Rollup of 10 pull requests #49489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save users the time/effort of having to lookup what types implement the `Try` trait.
This fixes building the compiler docs because stage1-rustc\x86_64-pc-windows-msvc\doc is used twice which doesn't work if we still have a handle from the first time.
vec::SpecFromElem provides an optimization to use calloc to fill a Vec when the element given to fill the Vec is represented by 0. For floats, the test for that currently used is `x == 0. && x.is_sign_positive()`. When compiled in a standalone function, rustc generates the following assembly: ``` xorps xmm1, xmm1 ucomisd xmm0, xmm1 setnp al sete cl and cl, al movq rax, xmm0 test rax, rax setns al and al, cl ret ``` A simpler test telling us whether the value is represented by 0, is `x.to_bits() == 0`, which rustc compiles to: ``` movq rax, xmm0 test rax, rax sete al ret ``` Not that the test is hot in any way, but it also makes it clearer what the intent in the rust code is.
It' only used for hash::Hasher, but Hasher is also imported.
Seems more useful to say that it has the same size as `*mut T`.
We only support stack probes on x86 and x86_64. Other arches are already ignored.
…, r=QuietMisdreavus Fix tooltip position r? @QuietMisdreavus
…Misdreavus Rename main theme into light theme r? @QuietMisdreavus
…r=GuillaumeGomez Explicitly mention `Option` in `?` error message. Save users the time/effort of having to lookup what types implement the `Try` trait.
Don't mention unstable constructors in release notes
…eak, r=alexcrichton rustbuild: Don't leak file handles when creating junctions on Windows This fixes building the compiler docs because stage1-rustc\x86_64-pc-windows-msvc\doc is used twice which doesn't work if we still have a handle from the first time.
Use f{32,64}::to_bits for is_zero test in vec::SpecFromElem
vec::SpecFromElem provides an optimization to use calloc to fill a Vec
when the element given to fill the Vec is represented by 0.
For floats, the test for that currently used is `x == 0. &&
x.is_sign_positive()`. When compiled in a standalone function, rustc
generates the following assembly:
```
xorps xmm1, xmm1
ucomisd xmm0, xmm1
setnp al
sete cl
and cl, al
movq rax, xmm0
test rax, rax
setns al
and al, cl
ret
```
A simpler test telling us whether the value is represented by 0, is
`x.to_bits() == 0`, which rustc compiles to:
```
movq rax, xmm0
test rax, rax
sete al
ret
```
Not that the test is hot in any way, but it also makes it clearer what
the intent in the rust code is.
Remove unnecessary use core::hash in liballoc/boxed.rs It' only used for hash::Hasher, but Hasher is also imported.
…labnik src/libcore/ptr.rs: Fix documentation for size of `Option<NonNull<T>>` Seems more useful to say that it has the same size as `*mut T`.
…alexcrichton Ignore stack-probes tests on powerpc/s390x too We only support stack probes on x86 and x86_64. Other arches are already ignored.
…abnik correct a typo in RELEASES.md
|
@bors r+ p=10 |
|
📌 Commit 67e0c2b has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionin?error message. #49446, Don't mention unstable constructors in release notes #49463, rustbuild: Don't leak file handles when creating junctions on Windows #49464, Use f{32,64}::to_bits for is_zero test in vec::SpecFromElem #49466, Remove unnecessary use core::hash in liballoc/boxed.rs #49468, src/libcore/ptr.rs: Fix documentation for size ofOption<NonNull<T>>#49473, Ignore stack-probes tests on powerpc/s390x too #49484, correct a typo in RELEASES.md #49486