Skip to content

ENH: Reduce verbosity of distributed plugin #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2017
Merged

ENH: Reduce verbosity of distributed plugin #2208

merged 1 commit into from
Oct 4, 2017

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 4, 2017

#2200 added nice detailed stats, but by default it will print every 2s even with no change.

Changes proposed in this pull request

  • Check for changes in statistics before printing
  • Set standard progress report to DEBUG level

@effigies effigies requested review from satra and oesteban October 4, 2017 17:28
oesteban
oesteban approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to merge when tests pass

@codecov-io
Copy link

codecov-io commented Oct 4, 2017 •
edited
Loading

Codecov Report

Merging #2208 into master will not change coverage.
The diff coverage is 92.85%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2208   +/-   ##
=======================================
  Coverage   72.25%   72.25%           
=======================================
  Files        1177     1177           
  Lines       58650    58650           
  Branches     8450     8450           
=======================================
  Hits        42378    42378           
  Misses      14905    14905           
  Partials     1367     1367
Flag Coverage Δ
#smoketests 72.25% <92.85%> (ø) ⬆️
#unittests 69.79% <78.57%> (ø) ⬆️
Impacted Files Coverage Δ
nipype/pipeline/plugins/base.py 58.52% <92.85%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fde2fb...8fce0af. Read the comment docs.

@oesteban oesteban merged commit 2e5f5fc into nipy:master Oct 4, 2017
@effigies effigies deleted the quiet_multiproc branch October 4, 2017 23:24
effigies added a commit to effigies/niworkflows that referenced this pull request Oct 4, 2017
@effigies
PIN: nipy/nipype master branch
a3f1303 
Includes nipy/nipype#2208
effigies added a commit to effigies/niworkflows that referenced this pull request Oct 5, 2017
@effigies
PIN: nipy/nipype master branch
dafbfda 
Includes
 - nipy/nipype#2198
 - nipy/nipype#2200
 - nipy/nipype#2203
 - nipy/nipype#2205
 - nipy/nipype#2208
@effigies effigies mentioned this pull request Oct 5, 2017
Merged
effigies added a commit to effigies/niworkflows that referenced this pull request Oct 6, 2017
@effigies
PIN: nipy/nipype master branch
335e878 
Includes
 - nipy/nipype#2198
 - nipy/nipype#2200
 - nipy/nipype#2203
 - nipy/nipype#2205
 - nipy/nipype#2208
 - nipy/nipype#2211
 - nipy/nipype#2212
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oesteban oesteban oesteban approved these changes

@satra satra Awaiting requested review from satra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@effigies @codecov-io @oesteban @satra