-
Notifications
You must be signed in to change notification settings - Fork 532
[ENH] Minor Xvfb and MultiProcPlugin cleanups #2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I was just about to comment about |
LGTM - one little thing that could be useful is supplementing the information when running a Currently, this is output in the log
which is nice, but maybe we can add the node/function name in this case to get a better understanding? This could also be addressed in an add-on PR |
What do you think of 5b367f2? |
Hopefully this will polish those little things here and there. Thanks a lot @effigies |
Reviewed Oscar's changes. I'm +1 to merge if tests pass. |
…dd tests for this
cfe9f5b
to
ef7ccb0
Compare
Codecov Report
@@ Coverage Diff @@
## master #2211 +/- ##
=========================================
+ Coverage 72.3% 72.3% +<.01%
=========================================
Files 1178 1178
Lines 58736 58768 +32
Branches 8456 8458 +2
=========================================
+ Hits 42468 42494 +26
- Misses 14896 14901 +5
- Partials 1372 1373 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2211 +/- ##
======================================
Coverage 72.3% 72.3%
======================================
Files 1178 1178
Lines 58768 58768
Branches 8458 8458
======================================
Hits 42494 42494
Misses 14901 14901
Partials 1373 1373
Continue to review full report at Codecov.
|
Quick follow-up to #2200, #2203, #2208.
Changes proposed in this pull request
MultiProcPlugin._send_proc_to_workers
stats between calls to reduce noise