FIX: Create out_reg_file correctly in RobustRegister #2205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
force-pushed
the
fix/robust_register
branch
from
82b13de to
758251a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2205 +/- ##
==========================================
+ Coverage 72.25% 72.28% +0.02%
==========================================
Files 1177 1175 -2
Lines 58638 58770 +132
Branches 8447 8456 +9
==========================================
+ Hits 42369 42481 +112
- Misses 14902 14930 +28
+ Partials 1367 1359 -8
Continue to review full report at Codecov.
|
effigies
force-pushed
the
fix/robust_register
branch
from
f0885d1 to
efaaaa2
Compare
oesteban
approved these changes
Oct 4, 2017
|
I'll go ahead and merge, then. |
effigies
added a commit
to effigies/niworkflows
that referenced
this pull request
Oct 4, 2017
2 tasks
effigies
added a commit
to effigies/niworkflows
that referenced
this pull request
Oct 5, 2017
effigies
added a commit
to effigies/niworkflows
that referenced
this pull request
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RobustRegister does not correctly return the full path to manually-specified
out_reg_filenames, and, if unspecified, creates them in the original folder.Changes proposed in this pull request
out_reg_filea normalEither(True, File)trait, with default valueTrueout_reg_fileis created in working directory by defaultAlso did some cleanup. See 5be5de9 for significant changes.