Rollup of 7 pull requests #140633
Merged
Rollup of 7 pull requests #140633
+543
−226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xizheyin <[email protected]>
Signed-off-by: xizheyin <[email protected]>
Fix the test for s390x by enabling s390x vector extension via `target_feature(enable = "vector")`(rust-lang#127506). As this is is still gated by `#![feature(s390x_target_feature)]` we need that attribute also.
Signed-off-by: xizheyin <[email protected]>
To avoid having target-dependent "unwinding panics are not supported without std" errors, without regressing test intention.
Add the AVX10 target features Parent rust-lang#138843 Adds the `avx10_target_feature` feature gate, and `avx10.1` and `avx10.2` target features. It is confirmed that Intel is dropping AVX10/256 (see [this comment](rust-lang#111137 (comment))), so this should be safe to implement now. The LLVM fix for llvm/llvm-project#135394 was merged, and has been backported to LLVM20, and the patch has also been propagated to rustc in rust-lang#140502 `@rustbot` label O-x86_64 O-x86_32 A-target-feature A-SIMD
Check if format argument is identifier to avoid error err-emit Fixes rust-lang#139104 When `argument` is not an identifier, it should not be considered a field access. I checked this and if not emit an invalid format string error. I think we could do with a little finer error handling, I'll open an issue to track this down later. The first commit submits the ui test, the second commits the code and the changes to the test output. r? compiler
…ins_dyn, r=wesleywiser Fix test simd/extract-insert-dyn on s390x Fix the test for s390x by enabling s390x vector extension via `target_feature(enable = "vector")`(rust-lang#127506). As this is is still gated by `#![feature(s390x_target_feature)]` we need that attribute also.
Move some tests out of tests/ui r? `@jieyouxu`
Adjust some ui tests re. target-dependent errors Alternatives to optional error annotations in rust-lang#140586: - Continue to ignore target-dependent additional errors in `tests/ui/panic-runtime/{two-panic-runtimes.rs,tests/ui/panic-runtime/want-abort-got-unwind.rs,tests/ui/panic-runtime/want-abort-got-unwind2.rs}` -- but explain why some targets have more errors than others. - Use `-Cpanic=abort` for `tests/ui/cfg/cfg_false_no_std-2.rs`. In that test, the panic strategy does not matter w.r.t. test intention. - Adjust FIXMEs in `tests/ui/debuginfo/debuginfo-type-name-layout-ice-94961-2.rs` to track it in rust-lang#140620. --- try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1
…eyouxu Report the `unsafe_attr_outside_unsafe` lint at the closest node This PR have `AstValidation` track a linting node id and then uses it when reporting the `unsafe_attr_outside_unsafe` lint, so that instead of being bound at the crate-root, `#[allow]` of the lint works at any node. Fixes rust-lang#140602 r? `@jieyouxu`
…manieu allow `#[rustfmt::skip]` in combination with `#[naked]` fixes rust-lang#140623 We very deliberately use an allowlist to prevent weird interactions with `#[naked]`, hopefully we've now found all of the useful combinations. cc `@Amanieu`
rustbot
added
A-attributes
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 1239f49 with merge 622ac043764d5d4ffff8de8cf86a1cc938a8a71b... |
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 1bea580f36 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 1bea580 (parent) -> 622ac04 (this PR) Test differencesShow 45 test diffsStage 1
Stage 2
Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 622ac043764d5d4ffff8de8cf86a1cc938a8a71b --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced May 4, 2025
|
Finished benchmarking commit (622ac04): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.2%, secondary -1.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.9%, secondary 2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 770.15s -> 770.602s (0.06%) |
|
@rust-timer build 9a2955b |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (9a2955b): comparison URL. Overall result: no relevant changes - no action neededInstruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -0.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 770.15s -> 770.37s (0.03%) |
|
@rust-timer build 4841a77 |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (4841a77): comparison URL. Overall result: no relevant changes - no action neededInstruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 0.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -0.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 770.15s -> 770.268s (0.02%) |
|
@rust-timer build 7d485f8 |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (7d485f8): comparison URL. Overall result: ❌ regressions - please read the text belowInstruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.3%, secondary -1.3%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.7%, secondary 2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 770.15s -> 771.2s (0.14%) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2025
[DO NOT MERGE] Check the perf impact of reverting rust-lang#139675 According to rust-lang#140633 (comment), the changes in rust-lang#139675 caused many measurable perf regressions. We can double-check that result by benchmarking a revert. --- This reverts commit ed7590f, reversing changes made to 3559e0a. r? ghost
|
The regression was caused by #139675 (see also #140652). Since this really only affects helloworld and is just a tiny icount regression for larger crates, and it is expected that the perf. regression will be resolved in the next LLVM upgrade, I think that it's fine if we just eat the regression for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
unsafe_attr_outside_unsafelint at the closest node #140617 (Report theunsafe_attr_outside_unsafelint at the closest node)#[rustfmt::skip]in combination with#[naked]#140626 (allow#[rustfmt::skip]in combination with#[naked])r? @ghost
@rustbot modify labels: rollup
Create a similar rollup