Skip to content

Updates to support Cocoapods for RN 0.62 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 31, 2020

Conversation

robertmurray
Copy link
Contributor

Added License file and podspec to support CocaPods for RN 0.62. Updated package.json.

@zanechua
Copy link
Contributor

Do you not need to bump the s.platform to iOS 10.0 and above? The latest zendesk pods require you to use iOS 10.0 and above.

@fbartho
Copy link
Contributor

fbartho commented Jan 30, 2020

Nice catch @zanechua — do you see any other details we should fix? Before this, we weren’t using cocoapods in our main projects.

@zanechua
Copy link
Contributor

zanechua commented Jan 30, 2020

Yes. There are actually a few changes that I've made to my own fork of this repo. Was just speaking to the authors that were listed inside the package.json about the changes to allow Podspecs via email.

In this PR I see that the docs were updated to require you to include the RNZendeskChat Pod and to import the header files directly into our projects but that shouldn't be necessary because of updates to RN0.6x and above.

I've made the changes in my repo and referenced them below. In my own react-native app, we do not have to add any code at all into the Podfile. We just add the react-native-zendesk-chat package and we're good to go for iOS.

zanechua/react-native-zendesk-chat@117e224

EDIT: I've opened 2 PRs from a newly forked repo as that makes it cleaner.

The current version that is working with RN0.6x and auto-linking is at https://github.com/zanechua/react-native-zendesk-chat

@fbartho fbartho added this to the 0.3.0: RN 0.62 Support milestone Jan 30, 2020
@robertmurray robertmurray merged commit 5a21967 into master Jan 31, 2020
@zanechua
Copy link
Contributor

zanechua commented Feb 1, 2020

@robertmurray any reason why we're not using auto-linking and still requiring the manual import of the zendesk header files?

@fbartho fbartho deleted the rm/rn0.62-update-podspec branch July 9, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants