Skip to content

PIN: Update nipype #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2017
Merged

PIN: Update nipype #197

merged 1 commit into from
Oct 6, 2017

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 4, 2017

Includes nipy/nipype#2198, nipy/nipype#2200, nipy/nipype#2205

Pending:

Edit: Added a further pin. If that causes issues, I'll drop it.

@effigies
Copy link
Member Author

effigies commented Oct 5, 2017

@oesteban Do we need to include nipy/nipype#2209 to fix MRIQC?

@oesteban
Copy link
Member

oesteban commented Oct 5, 2017

No, I have to fix MRIQC first. Let me push some commits.

@effigies
Copy link
Member Author

effigies commented Oct 5, 2017

Okay. If it works for you, I'll push a commit here with the latest nipype PR and you can push your MRIQC fixes and pin in one shot.

@oesteban
Copy link
Member

oesteban commented Oct 5, 2017

It works :)

@oesteban
Copy link
Member

oesteban commented Oct 5, 2017

Sorry, I misread the thread. No, nipy/nipype#2209 is not necessary. Since it is failing to build we better hold off pinning to it.

@effigies
Copy link
Member Author

effigies commented Oct 5, 2017

Okay, I collapsed the pin to include all the updates. You can pin MRIQC to dafbfda.

@oesteban
Copy link
Member

oesteban commented Oct 5, 2017

Sweet thanks

@effigies
Copy link
Member Author

effigies commented Oct 5, 2017

Updated the fmriprep test in the checklist. If you want to do the same when you push an mriqc branch, I'll merge when they both pass.

@oesteban
Copy link
Member

oesteban commented Oct 5, 2017

Done

Copy link
Member

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if MRIQC passes :)

@effigies
Copy link
Member Author

effigies commented Oct 5, 2017

Not causing a failure but it is a bit unsightly:

Error in atexit._run_exitfuncs:

Traceback (most recent call last):
  File "/usr/local/miniconda/lib/python3.6/site-packages/niworkflows/nipype/utils/config.py", line 327, in free_display
    config.stop_display()
AttributeError: 'NipypeConfig' object has no attribute 'stop_display'

From: https://circleci.com/api/v1.1/project/github/effigies/fmriprep/861/output/31/0?file=true

I want to go ahead and merge to move forward, if MRIQC passes, but just so you're aware of the issue.

@oesteban
Copy link
Member

oesteban commented Oct 5, 2017

That is because of the absolute import of nipype in the atexit function (it should try niworkflows.nipype instead). Not sure if that import could be relative, I guess so.

@effigies
Copy link
Member Author

effigies commented Oct 5, 2017

Yup. I'm submitting a patch. Also dropping the verbosity of multi-proc again...

@effigies effigies merged commit 2712471 into nipreps:master Oct 6, 2017
@effigies effigies deleted the pin/nipype_2198 branch October 6, 2017 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants