-
Notifications
You must be signed in to change notification settings - Fork 53
PIN: Update nipype #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIN: Update nipype #197
Conversation
@oesteban Do we need to include nipy/nipype#2209 to fix MRIQC? |
No, I have to fix MRIQC first. Let me push some commits. |
Okay. If it works for you, I'll push a commit here with the latest nipype PR and you can push your MRIQC fixes and pin in one shot. |
It works :) |
Sorry, I misread the thread. No, nipy/nipype#2209 is not necessary. Since it is failing to build we better hold off pinning to it. |
a3f1303
to
dafbfda
Compare
Okay, I collapsed the pin to include all the updates. You can pin MRIQC to dafbfda. |
Sweet thanks |
Updated the fmriprep test in the checklist. If you want to do the same when you push an mriqc branch, I'll merge when they both pass. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if MRIQC passes :)
Not causing a failure but it is a bit unsightly:
From: https://circleci.com/api/v1.1/project/github/effigies/fmriprep/861/output/31/0?file=true I want to go ahead and merge to move forward, if MRIQC passes, but just so you're aware of the issue. |
That is because of the absolute import of |
Yup. I'm submitting a patch. Also dropping the verbosity of multi-proc again... |
dafbfda
to
335e878
Compare
Includes nipy/nipype#2198, nipy/nipype#2200, nipy/nipype#2205
Pending:
Edit: Added a further pin. If that causes issues, I'll drop it.