Skip to content

Merge PR #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 80 commits into from
Closed

Merge PR #290

wants to merge 80 commits into from

Conversation

rahuljhakant
Copy link
Contributor

@rahuljhakant rahuljhakant commented Mar 7, 2020

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I am attaching a screenshot showing the before and after)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

harsha509 and others added 30 commits February 14, 2020 10:24
- grid/_index.ja.md
- grid/components_of_a_grid.ja.md
- grid/purposes_and_main_functionalities.ja.md
- grid/setting_up_your_own_grid.ja.md
- grid/when_to_use_grid.ja.md

Co-authored-by: Diego Molina <[email protected]>
- driver_idiosyncrasies/_index.ja.md
- driver_idiosyncrasies/driver_specific_capabilities.ja.md
- driver_idiosyncrasies/shared_capabilities.ja.md
- support_packages/_index.ja.md
- support_packages/browser_navigation.ja.md
- support_packages/working_with_colours.ja.md
- support_packages/working_with_select_elements.ja.md
- support_packages/working_with_cookies.ja.md

Co-authored-by: Diego Molina <[email protected]>
- introduction/the_selenium_project_and_tools.ja.md
- introduction/on_test_automation.ja.md
- introduction/types_of_testing.ja.md
- introduction/about_this_documentation.ja.md

Co-authored-by: Diego Molina <[email protected]>
… document (#241) [deploy site]

Signed-off-by: Sri Harsha <[email protected]>

Co-authored-by: Diego Molina <[email protected]>
selenium-ci and others added 27 commits February 23, 2020 18:06
- webdriver/page_loading_strategy.ja.md

Co-authored-by: Diego Molina <[email protected]>
- webdriver/keyboard.zh-cn.md

Co-authored-by: Diego Molina <[email protected]>
…loy site]

Signed-off-by: Sri Harsha <[email protected]>

Co-authored-by: Diego Molina <[email protected]>
- introduction/on_test_automation.zh-cn.md

Co-authored-by: Diego Molina <[email protected]>
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
6 out of 7 committers have signed the CLA.

✅ kzhirata
✅ diemol
✅ boris779
✅ Harsha509
✅ YoshikiIto
✅ alaahong
❌ selenium-ci
You have signed the CLA already but the status is still pending? Let us recheck it.

@rahuljhakant
Copy link
Contributor Author

Will submit a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants