Skip to content

MFTF 2.3.7 - Merge to Master #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Oct 3, 2018
Merged

MFTF 2.3.7 - Merge to Master #241

merged 23 commits into from
Oct 3, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Merge 2.3.7 contents to master.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

jilu1 and others added 20 commits September 10, 2018 13:45
…arameterArray

- addressed static test failures
- new .env DEFAULT_TIMEZONE, defaults to 'America/Los_Angeles'
- generateDate now uses this value (or override if provided)
- DEFAULT_TIMEZONE and timezone attribute are now checked in generation; fast fail in generation as opposed to run-time
MQE-1142: Use timeout value when waitForLoadingMaskToDisappear
MQE-1065: Persisted data are not resolved correctly when using with ParameterArray
…ly (#226)

* MQE-1040: MFTF standalone commands do not pass down constants correctly

- Updated Magento_bp and Tests_bp to be set after env is loaded
- Updated standalone bootstrap to use different relative module path if magento_bp is set

* MQE-1040: MFTF standalone commands do not pass down constants correctly

- Updated filename

* MQE-1040: MFTF standalone commands do not pass down constants correctly

- Changed define to add defined
- Added default value for $timeout attribute (causing issues with CE tests)
- Added check to ascertain browser is among the available log types
…ly (#232)

* MQE-1040: MFTF standalone commands do not pass down constants correctly

- Corrected original ticket
- Changed functional run location from alternate Magento Directory to project directory whether standalone or in vendor

* MQE-1040: MFTF standalone commands do not pass down constants correctly

- Removing commented line
…cter

- Made regex more flexible, should accept any character except for ones that break the pattern.
…ement

- parent is now included in exception output
#228)

* MQE-1124: [Github Issue] Allow running tests for modules installed in Magento instance via vendor directory. #162

- Adjusted Module Resolver to look Recursively from Project Root, Magento BP and dev/tests
- Updated Module Resolver Unit Tests to reflect changes

* MQE-1124: [Github Issue] Allow running tests for modules installed in Magento instance via vendor directory. #162

- Reintroduced recursive_merge to prevent similar directories with different contents being missed

* MQE-1124: [Github Issue] Allow running tests for modules installed in Magento instance via vendor directory.

- Updated to include checking through registered Magento modules

* MQE-1124: [Github Issue] Allow running tests for modules installed in Magento instance via vendor directory.

- Used class constant instead of just adding it

* MQE-1124: [Github Issue] Allow running tests for modules installed in Magento instance via vendor directory.

- Adding requested changes

* MQE-1124: [Github Issue] Allow running tests for modules installed in Magento instance via vendor directory.

- Specified additional error in case of bad Magento basepath
… on file (#234)

* MQE-1173: [Dev experience] Error on test generation without reference on file

- Added error messaging at Action level
- Extended range of errors caught at Test level
- Added unit tests for Exception catching for TestGenerator and ActionMergeUtil

* MQE-1173: [Dev experience] Error on test generation without reference on file

- Removed unused use cases

* MQE-1173: [Dev experience] Error on test generation without reference on file

- Removed use

* MQE-1173: [Dev experience] Error on test generation without reference on file

- Added setting parameter list to [] in case of no parameters

* MQE-1173: [Dev experience] Error on test generation without reference on file

- Moved count out of matching method

* MQE-1173: [Dev experience] Error on test generation without reference on file

- Made requested changes
- Updated unit tests to be a bit more descriptive
- Added support for passing in data into arguments as `{{mydata.value}}`
- Actiongroup and test dom classes now check for duplicate child <test> and <actionGroup> elements.
* MQE-1117: dontSeeJsError does not catch JS errors

- changed to only check js errors in current page
- bug fix
- Syntax issue in ErrorLogger.php fixed.
- Changelog update with 2.3.7 items
- version bump in composer and lock file
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 57.516% when pulling a4e0a9b on develop into 57021e1 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 57.516% when pulling a4e0a9b on develop into 57021e1 on master.

@coveralls
Copy link

coveralls commented Oct 2, 2018

Coverage Status

Coverage increased (+0.4%) to 57.524% when pulling 0a3ef3a on develop into 57021e1 on master.

tomreece
tomreece previously approved these changes Oct 2, 2018
- Added check for null driver to prevent php fatal error
aljcalandra
aljcalandra previously approved these changes Oct 3, 2018
* Update formatting and links
* Fix formatting and style
- Copy content from devdocs
- Convert to GFM
- Review and update
- Add table of contents
@KevinBKozan KevinBKozan merged commit ece8ef6 into master Oct 3, 2018
magento-devops-reposync-svc pushed a commit that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants